Skip to content

refactor: stale file test package migration [GKE-GCSFuse Test migration]#3884

Merged
PranjalC100 merged 7 commits into
masterfrom
test-migration-stale-handle-1
Dec 4, 2025
Merged

refactor: stale file test package migration [GKE-GCSFuse Test migration]#3884
PranjalC100 merged 7 commits into
masterfrom
test-migration-stale-handle-1

Conversation

@PranjalC100

Copy link
Copy Markdown
Member

Description

This PR includes changes to migrate stale file test package to use common config file. This common config will be used by both GCSFuse binary and GCSFuse csi driver tests.

Changes include:

refactoring to use config file by test methods.
changes are made in a backward compatible way so tests can run with both config file and flags. This will be cleaned up in future PRs after the migration is complete.
Migration of stale file package so it can use config file.

Link to the issue in case of a bug fix.

b/445952888

Testing details

  1. Manual - Manually tested with config file for both cases when mounted directory is set and not set. Also validated that the tests work without config file.
  2. Unit tests - NA
  3. Integration tests - via KOKORO

Any backward incompatible change? If so, please explain.

@PranjalC100 PranjalC100 requested review from a team and Tulsishah as code owners October 14, 2025 05:18
@PranjalC100 PranjalC100 changed the base branch from master to read-cache-test-migration October 14, 2025 05:18
@PranjalC100 PranjalC100 changed the title refactor: slale file test package migration [GKE-GCSFuse Test migration] refactor: stale file test package migration [GKE-GCSFuse Test migration] Oct 14, 2025
@PranjalC100 PranjalC100 changed the base branch from read-cache-test-migration to master October 14, 2025 05:21
@PranjalC100 PranjalC100 changed the base branch from master to read-cache-test-migration October 14, 2025 05:22
@PranjalC100 PranjalC100 force-pushed the test-migration-stale-handle-1 branch from e4e47ae to 37024db Compare October 14, 2025 05:25
@PranjalC100 PranjalC100 changed the title refactor: stale file test package migration [GKE-GCSFuse Test migration] refactor: stale file test package migration [GKE-GCSFuse Test migration] [DNR yet] Oct 14, 2025
@ashmeenkaur ashmeenkaur force-pushed the read-cache-test-migration branch from 4a40d84 to e9f8fa9 Compare October 14, 2025 08:38
@ashmeenkaur ashmeenkaur force-pushed the test-migration-stale-handle-1 branch from 37024db to 3afe4bb Compare October 14, 2025 09:11
@PranjalC100 PranjalC100 added the execute-integration-tests Run only integration tests label Oct 22, 2025
@codecov

codecov Bot commented Oct 22, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (f48d62d) to head (8058db5).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #3884       +/-   ##
==========================================
- Coverage   83.29%       0   -83.30%     
==========================================
  Files         153       0      -153     
  Lines       18624       0    -18624     
==========================================
- Hits        15513       0    -15513     
+ Misses       2542       0     -2542     
+ Partials      569       0      -569     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PranjalC100 PranjalC100 force-pushed the test-migration-stale-handle-1 branch from b9ffbdf to b4e810e Compare October 22, 2025 14:44
@PranjalC100 PranjalC100 changed the base branch from read-cache-test-migration to master October 22, 2025 14:45
@PranjalC100 PranjalC100 force-pushed the test-migration-stale-handle-1 branch from b4e810e to ad84e02 Compare October 22, 2025 14:55
@PranjalC100 PranjalC100 force-pushed the test-migration-stale-handle-1 branch 9 times, most recently from 0240da6 to b30cf43 Compare November 13, 2025 07:37
Comment thread tools/integration_tests/stale_handle/stale_file_handle_synced_file_test.go Outdated
Comment thread tools/integration_tests/stale_handle/stale_file_handle_common_test.go Outdated
@PranjalC100 PranjalC100 force-pushed the test-migration-stale-handle-1 branch from b30cf43 to dad6900 Compare November 13, 2025 08:28
@PranjalC100 PranjalC100 force-pushed the test-migration-stale-handle-1 branch 2 times, most recently from 4a4237c to 61d0091 Compare November 13, 2025 09:02
@PranjalC100 PranjalC100 changed the title refactor: stale file test package migration [GKE-GCSFuse Test migration] [DNR yet] refactor: stale file test package migration [GKE-GCSFuse Test migration] Nov 13, 2025
@PranjalC100 PranjalC100 force-pushed the test-migration-stale-handle-1 branch 2 times, most recently from eaeec53 to 250ad08 Compare November 13, 2025 09:39
@PranjalC100 PranjalC100 force-pushed the test-migration-stale-handle-1 branch from 250ad08 to 31de7ec Compare November 13, 2025 11:06
Comment thread tools/integration_tests/test_config.yaml Outdated
@PranjalC100 PranjalC100 enabled auto-merge (squash) December 4, 2025 04:03
@PranjalC100 PranjalC100 merged commit 338ee35 into master Dec 4, 2025
13 checks passed
@ashmeenkaur ashmeenkaur deleted the test-migration-stale-handle-1 branch December 4, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants