always set sidecar bucket access check env variable #1081
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
#1053 added a check where the env variable for enable_sidecar_bucket_access_check is set only if a. the driver is unmanaged b. the sidecar version is supported for managed driver. While the environment variable is conditionally set we always try to fetch the value for the env variable
TEST_WITH_SIDECAR_BUCKET_ACCESS_CHECKduring tests this was causing fatal errors in the testsuite. I have now updated the logic to always set the env variable irrespective of driver version.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Verified the test run is triggered correctly
Does this PR introduce a user-facing change?: