Remove visibilitychange listener after use #588
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
williazz
reviewed
Mar 19, 2025
| } else { | ||
| handle = rIC(cb); | ||
| onHidden(cb); | ||
| onHidden(cb, { once: true }); |
There was a problem hiding this comment.
Issue: This may not work because the once parameter does not take into account if the visibility state was hidden, preventing the callback from being invoked.
if (document.visibilityState === 'hidden') {
cb();
}
Member
|
Thanks for the PR. However chunks of this have been rewritten in the v5 branch and I don't think this applies anymore. In particular thanks to #541. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #554, we want to remove those event listeners after they've been used.