Skip to content

tests: parallelize lantern database tests #16545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
connorjclark merged 1 commit into from
Jun 18, 2025
Merged

tests: parallelize lantern database tests #16545

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions core/scripts/lantern/run-on-all-assets.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,17 @@
/** @typedef {{sites: GoldenSite[]}} Golden */

import fs from 'fs';
import os from 'os';
import path from 'path';
import {execFileSync} from 'child_process';
import childProcess from 'child_process';
import util from 'util';

import constants from './constants.js';
import {LH_ROOT} from '../../../shared/root.js';
import {readJson} from '../../test/test-utils.js';
import {ConcurrentMapper} from '../../../cli/test/smokehouse/lib/concurrent-mapper.js';

const execFile = util.promisify(childProcess.execFile);

const INPUT_PATH = process.argv[2] || constants.SITE_INDEX_WITH_GOLDEN_PATH;
const SITE_INDEX_PATH = path.resolve(process.cwd(), INPUT_PATH);
Expand All @@ -35,22 +40,25 @@ if (!fs.existsSync(SITE_INDEX_PATH)) throw new Error('Usage $0 <expectations fil
/** @type {Golden} */
const expectations = readJson(SITE_INDEX_PATH);

for (const site of expectations.sites) {
const concurrency = process.env.CI ?
os.cpus().length :
Math.max(os.cpus().length - 2, 1);
console.log(`Running across ${concurrency} processes ...`);

await ConcurrentMapper.map(expectations.sites, async (site) => {
const trace = path.join(SITE_INDEX_DIR, site.unthrottled.tracePath);
const log = path.join(SITE_INDEX_DIR, site.unthrottled.devtoolsLogPath);

console.log('Running', site.url, '...');
try {
const rawOutput = execFileSync(RUN_ONCE_PATH, [trace, log])
.toString()
.trim();
if (!rawOutput) console.log('ERROR EMPTY OUTPUT!');
const rawOutput = (await execFile(RUN_ONCE_PATH, [trace, log])).stdout.trim();
if (!rawOutput) console.log(site.url, 'ERROR EMPTY OUTPUT!');
const lantern = JSON.parse(rawOutput);
Object.assign(site, {lantern});
} catch (e) {
console.error(e);
console.error(site.url, e);
}
}
}, {concurrency});

// eslint-disable-next-line max-len
fs.writeFileSync(constants.SITE_INDEX_WITH_GOLDEN_WITH_COMPUTED_PATH, JSON.stringify(expectations, null, 2));