Skip to content

Conversation

@connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented Jul 9, 2022

Fixes #14171

I'm using my fork from my PR to quibble: testdouble/quibble#71

Also fix a couple things related to windows paths (done in #14464).

@connorjclark
Copy link
Collaborator Author

connorjclark commented Jul 9, 2022

Note: the quibble PR fixes things related to mocking ES modules. We only do a handful of mocks for ES modules in master right now, so this isn't a great test of the quibble PR. I merged this PR (14202) into the core ESM PR (#14182) and get a handful of test failures related to ESM mocks, so there's still more to do there. But it seems at least the basic usage we do atm in master is working. It also may be that quibble is fine now, and the bug exists in our code re: proper usage of import.

Mostly writing this as a reminder to myself to look into this Monday.

@connorjclark
Copy link
Collaborator Author

I believe I fixed all of the windows issues. The remaining test failures remind me of what #14216 is meant to avoid, so let's wait for that to land first.

@connorjclark
Copy link
Collaborator Author

Passing in CI, and confirmed to work locally. At least, unit-cli does.

Some core tests (like pptr scenarios) hang on the after hook. Something to look into one day, but not high priority.

@connorjclark connorjclark merged commit 8c61b74 into main Nov 29, 2022
@connorjclark connorjclark deleted the win-quibble-fix-tests branch November 29, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-enable yarn unit-cli in CI on windows

5 participants