add special handeling of too long path's#692
Merged
JoC0de merged 1 commit intoGlitchEnzo:masterfrom Jan 14, 2025
Merged
Conversation
igor84
approved these changes
Jan 6, 2025
Collaborator
igor84
left a comment
igor84
left a comment
There was a problem hiding this comment.
Still can hit the problem but I guess it reduced a chance for it a bit.
Collaborator
Author
|
@igor84 The only problem I see is that it will not produce consistent results on different machines when someone places the same Unity project in a "longer" path and gets e.g. the issue that a DLL is not found beaus it doesn't have the same name. To really solve the inconsistency we would need a setting that forces the path shortening. Eventually we can make the whole Path shortening optional so the user knows that it happens but probably the potential issues will occur when the user forgot that he enabled it. But I think all of this is relay an edge case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #688