Conversation
popara96
approved these changes
Dec 14, 2023
JoC0de
approved these changes
Dec 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out I didn't properly handle the plugin path. I didn't make sure that it is saved as relative path and that it was turned into an absolute path when used in Cli version.
I also updated main workflow to use new net8.0 LTS for packaging nuget packages which will also means that Cli version will require it to run from now on instead of net7.0.
Besides that I also exposed INugetPackageIdentifier.Version and INuspecFile.Id setters to plugins so they can modify the default nuspec file for new packages. Another such thing is PackageInstallDir that is now exposed on INugetPluginService.
UninstallAll method is made public instead of internal so users can for example add a menu item for it if they want.
Lastly I added one more extension point for handling found installed packages when they are loaded from PackageInstalledDir or RepositoryPath as we call it in NugetConfigFile.