Skip to content

Update ReleaseNotesTrait and AutoUpdateTrait #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balagan73 merged 11 commits into from
Mar 27, 2026
Merged

Update ReleaseNotesTrait and AutoUpdateTrait #986

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8d867d8
Run composer audit when udpating.
balagan73 Feb 6, 2026
7e1e548
Phpcs fix.
balagan73 Feb 6, 2026
5c1c320
Update robo-components/AutoUpdateTrait.php
balagan73 Feb 18, 2026
d5aef75
Fix unable to parse ... as it does not exist error.
balagan73 Feb 25, 2026
9306484
Merge branch 'main' into run-composer-audit
balagan73 Mar 23, 2026
07ca0ed
Handle old #xxxx pattern in PR description, but only at start.
balagan73 Mar 18, 2026
530898e
Remove unnecessary api call.
balagan73 Mar 19, 2026
bd3fffa
Phpcs fix.
balagan73 Mar 23, 2026
58e9d12
Update robo-components/ReleaseNotesTrait.php
balagan73 Mar 27, 2026
1966687
Update robo-components/AutoUpdateTrait.php
balagan73 Mar 27, 2026
073fd61
Update robo-components/AutoUpdateTrait.php
balagan73 Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion robo-components/AutoUpdateTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ public function updateModules() {
}
$this->say("Update module is installed, checking status of projects.");
$this->say("In case of some errors manually loading /admin/reports/updates can help.");
$this->yell("Don't forget to run ddev drush updb manually at the end!");

if (!($available = update_get_available(TRUE))) {
$this->say("Cannot fetch info about the releases.");
Expand Down Expand Up @@ -125,6 +124,12 @@ public function updateModules() {
$git_command = "git commit -m 'Update " . $package . ' to ' . $version . "'";
$this->taskExec($git_command)->printOutput(TRUE)->run();
}
// Composer audit can show vulnerabilities.
$exit_code = $this->taskExec('bash -lc "exec composer audit"')
Comment thread
balagan73 marked this conversation as resolved.
Outdated
->printOutput(TRUE)
->run();
$this->yell("Now run ddev drush updb manually!");

}

}
2 changes: 1 addition & 1 deletion web/modules/custom/server_migrate/src/Plugin/migrate/process/MediaEmbedProcessPluginBase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ protected function isImageSource(string $path) {
* @throws \Exception
*/
protected function getFileNameFromPath(string $path) {
$file_name = $this->fileSystem->basename($path);
$file_name = basename($path);
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getFileNameFromPath() no longer uses $this->fileSystem, and a repo-wide search shows no other references to $this->fileSystem in this class. This leaves an unused FileSystemInterface import/property (and likely unused service injection in subclasses), which is confusing and can drift over time. Either revert to using the Drupal file system service here, or remove the unused property/import and any related injection.

Suggested change
$file_name = basename($path);
$file_name = $this->fileSystem->basename($path);

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor Author

@balagan73 balagan73 Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FileSystemInterface::basename() was deprecated in Drupal 9.3 and removed in Drupal 11. Use PHP's native basename() instead:

if (empty($file_name)) {
throw new \Exception(sprintf('File name cannot be found for path: %s', $path));
}
Expand Down
Loading