Add ability to build responsive image styles in style guide#982
Open
dipakmdhrm wants to merge 2 commits intomainfrom
Open
Add ability to build responsive image styles in style guide#982dipakmdhrm wants to merge 2 commits intomainfrom
dipakmdhrm wants to merge 2 commits intomainfrom
Conversation
dipakmdhrm
force-pushed
the
981-style-guide-responsive-images
branch
from
44e1ce5 to
08472dc
Compare
dipakmdhrm
force-pushed
the
981-style-guide-responsive-images
branch
from
08472dc to
8dba918
Compare
amitaibu
reviewed
Jan 31, 2026
| * @return array | ||
| * A render array for a <picture> element. | ||
| */ | ||
| private function buildResponsiveImage(array $image_dimensions, string $id = '', string $id_type = 'id', string $alt = ''): array { |
Member
There was a problem hiding this comment.
stringshould normally be replaced with an enum- Can we call an actual responsive image, like used in the Themetrits / PEVB, instead of building one ourselves?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#981
Update:
server_theme