Conversation
| site_key: '' | ||
| secret_key: '' |
There was a problem hiding this comment.
Doesn't it require the key to work?
Will it work on different envs (local/ QA/ TEST/ LIVE)?
There was a problem hiding this comment.
@amitaibu Yes, it requires a key to work. Also, we can add multiple domains to the same site setup in reCAPTCHA, so it doesn’t require separate keys for each environment.
There was a problem hiding this comment.
Thanks, then shouldn't we have the key as part of the config?
There was a problem hiding this comment.
I received a notification from GitGuardian that the reCAPTCHA key was exposed on GitHub. That’s why I removed it.
There was a problem hiding this comment.
Oh, sorry, this is the drupal-starter repo :)
Since it was already exposed on Git, you should revoke those keys and create new ones.
There was a problem hiding this comment.
@amitaibu As per my understanding, no action is needed on this PR. I will proceed to revoke the site keys in reCAPTCHA.
There was a problem hiding this comment.
Please update README, as Captcha won't work without the keys
There was a problem hiding this comment.
@amitaibu Updated README.md
TB: 0.15h(0.65h/1h)
|
@amitaibu Please let me know if anything else needs to be updated in this PR. |
2 participants
#874
TB: 0.5h(0.5h/1h)