-
Notifications
You must be signed in to change notification settings - Fork 664
feat: support nuget.org Trusted Publishing via GitHub Actions OIDC #4884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+68
−6
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c483a48
Initial plan
Copilot 62df16f
feat: support nuget.org Trusted Publishing via GitHub Actions OIDC
Copilot 22980a2
fix: restore NuGet creds step and NUGET_API_KEY env var for fallback
Copilot 74227d4
docs: expand nuget.org Trusted Publishing setup instructions in CONTR…
Copilot a1bc95e
docs: correct nuget.org Trusted Publishing setup - one-time per repo,…
Copilot 494021c
Apply suggestions from code review
arturcic 12f1b78
fix: format CONTRIBUTING.md table and add missing System.Text using d…
Copilot b933173
fix: remove unnecessary System.Text using directive from PublishNuget.cs
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot implement this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The OIDC token exchange with static API key fallback was already implemented in
PublishNuget.cs. Updated the PR description in commit12f1b78to accurately reflect both the pipeline changes (PublishNuget.cs,_publish.yml) and the documentation updates.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The OIDC token exchange (with fallback to static
NUGET_API_KEY) is implemented inbuild/publish/Tasks/PublishNuget.cs. Also added the missingusing System.Text;import forEncoding.UTF8in commit12f1b78.