Reduce libgit2sharp dependency in the GitVersionCore project #2509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed fields that depend directly on Libgit2sharp Using proxy classes, and methods
|
🎉 This issue has been resolved in version 5.6.2 🎉 Your GitReleaseManager bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the dependecy on the LibGit2Sharp in the GitVersionCore project, by replacing the direct call to Libgit2Sharp.Repository and Libgit2Sharp.IRepository, as well as other LibGit2Sharp objects by replacing with proxy classes (git objects classes) like
GitRepository, Branch, Commit and so on.
The only classes that depend on Libgit2Sharp are placed in the LibGit2 folder.
That means when we will have a full managed implementation of the IGitRepository interface and the git objects we can remove the dependency on LibGit2Sharp in the Core, still for unit testing we might keep it