Skip to content

Fix #2292, add tests for config overriding #2294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 30, 2020
Merged

Fix #2292, add tests for config overriding #2294

merged 6 commits into from
May 30, 2020

Conversation

@Inok
Copy link
Contributor

@Inok Inok commented May 27, 2020 •
edited
Loading

Fixes #2292

@Inok Inok changed the title #2292 Failing test for config overrides, tests for tag-prefix overriding Fix #2292, add tests for config overriding May 27, 2020
@Inok Inok marked this pull request as draft May 27, 2020 22:45
@Inok Inok mentioned this pull request May 27, 2020
Closed
@Inok Inok marked this pull request as ready for review May 28, 2020 21:23
asbjornu
asbjornu approved these changes May 30, 2020
View reviewed changes
Copy link
Member

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fabulous!

@asbjornu asbjornu merged commit d7abddb into GitTools:master May 30, 2020
@asbjornu asbjornu added this to the 5.3.x milestone May 30, 2020
@asbjornu
Copy link
Member

asbjornu commented May 30, 2020

Thank you for your contributions, @Inok! 🙏

@arturcic arturcic removed this from the 5.3.x milestone May 30, 2020
@Inok Inok deleted the issue-2292 branch May 30, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asbjornu asbjornu asbjornu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] /overrideconfig breaks configuration

3 participants

@Inok @asbjornu @arturcic