Feature/output file #2251
Merged
Feature/output file #2251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturcic
force-pushed
the
feature/output-file
branch
from
6e385b3 to
e789c33
Compare
arturcic
force-pushed
the
feature/output-file
branch
from
e789c33 to
baa55fd
Compare
Member
Author
asbjornu
approved these changes
May 4, 2020
Member
asbjornu
left a comment
asbjornu
left a comment
There was a problem hiding this comment.
This looks great! The only thing I can't seem to find is an integration test for verifying that the file is actually written to disk.
Member
Author
Agree, I will add a couple of them, thanks |
Member
Author
|
@asbjornu integration tests added |
asbjornu
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #983