Add handling of Assembly attributes that do not end on a new line #2150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added tests that fail if we don't have a newline after Assembly attributes - Updated FileHelper to support commented out Assembly attributes that do not end with a new line
Member
|
Will this fix this issue as well? #1802 |
Member
|
I think we should merge this and see whether #2102 turns green. 👍 |
Member
|
Ok @asbjornu |
Member
|
Thank you for your contributions @KiLLeRRaT! 🙏 |
Contributor
Author
|
@asbjornu Not a problem, happy to help. Eagerly waiting on some of the other issues/PRs to be finalised and sorted out so I can upgrade my projects to ust 5.1.4. (I'm stuck with .NET472, build issues etc. Should be dealt to with some of the other PRs). Have a good one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1939 and #1802.