Skip to content

chore(deps): update griffe version constraint to >=1.0.0,<2.0.0 #2176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 11, 2025
Merged

chore(deps): update griffe version constraint to >=1.0.0,<2.0.0 #2176

merged 5 commits into from
Jun 11, 2025

Conversation

@davidberenstein1957
Copy link
Member

@davidberenstein1957 davidberenstein1957 commented Jun 11, 2025 •
edited
Loading

Description

Grifffe was causing issue with openai in the notebook for deeplearning.ai

Related Issue

Fixes #2174

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.
  • I've updated the pdm.lock running pdm update-lock (only applicable when pyproject.toml has been
    modified)

@davidberenstein1957 davidberenstein1957 linked an issue Jun 11, 2025 that may be closed by this pull request
ModuleNotFoundError: No module named 'griffe. docstrings' running notebooks on deeplearning.ai course's (https://learn.deeplearning.ai/courses/red-teaming-llm-applications) #2174
Closed
@davidberenstein1957 davidberenstein1957 added the Lockfile Temporary label to update pdm.lock label Jun 11, 2025
@github-actions github-actions bot removed the Lockfile Temporary label to update pdm.lock label Jun 11, 2025
@davidberenstein1957
chore(deps): refine nemoguardrails version constraint in `pyproject…
6f08e31 
….toml` to ensure compatibility with future updates
@davidberenstein1957 davidberenstein1957 added Lockfile Temporary label to update pdm.lock safe for build and removed safe for build labels Jun 11, 2025
@github-actions github-actions bot removed the Lockfile Temporary label to update pdm.lock label Jun 11, 2025
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@henchaves henchaves merged commit e53c8ae into main Jun 11, 2025
19 checks passed
@henchaves henchaves deleted the chore/2174-modulenotfounderror-no-module-named-griffe-docstrings-running-notebooks-on-deeplearningai-courses-httpslearndeeplearningaicoursesred-teaming-llm-applications branch June 11, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henchaves henchaves henchaves approved these changes

@kevinmessiaen kevinmessiaen Awaiting requested review from kevinmessiaen

Assignees

No one assigned

Labels

safe for build

Milestone

No milestone

3 participants

@davidberenstein1957 @henchaves