Skip to content

Conversation

@PierreMesure
Copy link
Contributor

Description

Fixes #2057

Related Issue

Fixes #2057

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.
  • I've updated the pdm.lock running pdm update-lock (only applicable when pyproject.toml has been
    modified)

@henchaves henchaves self-requested a review October 30, 2024 01:56
Copy link
Member

@henchaves henchaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well spotted! thanks a lot @PierreMesure

@henchaves henchaves changed the title testset.jsonL Update report testset file extension Oct 30, 2024
@henchaves henchaves merged commit e6823d1 into Giskard-AI:main Oct 30, 2024
17 checks passed
@PierreMesure PierreMesure deleted the testset_jsonl branch October 30, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Testset saved as ".json", not ".jsonl" when saving report

2 participants