Skip to content

Conversation

@PierreMesure
Copy link
Contributor

Description

Fixes #2046

Related Issue

#2046

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.
  • I've updated the pdm.lock running pdm update-lock (only applicable when pyproject.toml has been
    modified)

@henchaves henchaves self-requested a review October 22, 2024 13:54
@henchaves
Copy link
Member

@PierreMesure that's perfect! Thanks a lot for your contribution.

@henchaves henchaves merged commit acad411 into Giskard-AI:main Oct 25, 2024
17 checks passed
@PierreMesure
Copy link
Contributor Author

You're welcome, thanks for your work on Giskard!

@PierreMesure PierreMesure deleted the no_ascii branch October 29, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Non-ASCII characters in testsets and report JSON files

2 participants