Skip to content

Conversation

@henchaves
Copy link
Member

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.
  • I've updated the pdm.lock running pdm update-lock (only applicable when pyproject.toml has been
    modified)

@linear
Copy link

linear bot commented Jul 26, 2024

@sentry
Copy link

sentry bot commented Jul 26, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: giskard/llm/embeddings/openai.py

Function Unhandled Issue
try_get_openai_embeddings OpenAIError: The api_key client option must be set either by passing api_key to the client or by setting the O... ...
Event Count: 7
try_get_openai_embeddings OpenAIError: The api_key client option must be set either by passing api_key to the client or by setting the O... bs.rag...
Event Count: 4

Did you find this useful? React with a 👍 or 👎

@henchaves henchaves requested a review from kevinmessiaen July 26, 2024 10:01
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

@kevinmessiaen kevinmessiaen merged commit c4d6981 into main Aug 30, 2024
@kevinmessiaen kevinmessiaen deleted the feature/gsk-3652-add-set_embedding_model-method branch August 30, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants