Skip to content

Conversation

@princyiakov
Copy link
Contributor

Description

  • improve input parameters of all the tests

  • improve the docstring

  • add enron unit tests

  • parameterise the tests

  • [ x] 🥂 Improvement (non-breaking change which improves an existing feature)

@princyiakov princyiakov requested a review from andreybavt August 2, 2022 14:01
@princyiakov princyiakov marked this pull request as draft August 2, 2022 14:01
@princyiakov princyiakov marked this pull request as ready for review August 4, 2022 09:29
princyiakov and others added 3 commits August 22, 2022 16:03
# Conflicts:
#	giskard-ml-worker/ml_worker/testing/performance_tests.py
@princyiakov princyiakov requested a review from andreybavt August 26, 2022 08:41
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.4% 88.4% Coverage
0.0% 0.0% Duplication

@andreybavt andreybavt merged commit ee26d47 into main Aug 30, 2022
@Hartorn Hartorn deleted the GSK-234_improve_current_tests branch September 13, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants