Skip to content

Fixed system prompt extraction inside of the bedrock client #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 24, 2024
Merged

Fixed system prompt extraction inside of the bedrock client #1937

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69dc794
Fixed system prompt extracting of bedrock clients
kevinmessiaen May 22, 2024
70231e0
Updated condition
kevinmessiaen May 22, 2024
6011d1f
Fixed issue
kevinmessiaen May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions giskard/llm/client/bedrock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,17 +39,13 @@ def complete(
if "claude-3" not in self.model:
raise LLMConfigurationError(f"Only claude-3 models are supported as of now, got {self.model}")

# extract system prompt from messages
system_prompt = ""
if len(messages) > 1:
if messages[0].role.lower() == "user" and messages[1].role.lower() == "user":
system_prompt = messages[0].content
messages = messages[1:]

# Create the messages format needed for bedrock specifically
input_msg_prompt = []
system_prompts = []
for msg in messages:
if msg.role.lower() == "assistant":
if msg.role.lower() == "system":
system_prompts.append(msg.content)
elif msg.role.lower() == "assistant":
input_msg_prompt.append({"role": "assistant", "content": [{"type": "text", "text": msg.content}]})
else:
input_msg_prompt.append({"role": "user", "content": [{"type": "text", "text": msg.content}]})
Expand All @@ -60,7 +56,7 @@ def complete(
"anthropic_version": "bedrock-2023-05-31",
"max_tokens": max_tokens,
"temperature": temperature,
"system": system_prompt,
"system": "\n".join(system_prompts),
"messages": input_msg_prompt,
}
)
Expand Down