Skip to content

Disabled perturbation on date #1932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 17, 2024
Merged

Disabled perturbation on date #1932

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c748bf7
Disabled perturbation on date
kevinmessiaen May 17, 2024
0df428e
Merge branch 'main' into bug/disabled_perturbation_on_date
kevinmessiaen May 17, 2024
76eec02
Use `is_any_real_numeric_dtype`
kevinmessiaen May 17, 2024
ea7371d
Merge remote-tracking branch 'origin/bug/disabled_perturbation_on_dat…
kevinmessiaen May 17, 2024
62d9874
Fallback for pandas <2
kevinmessiaen May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion giskard/push/perturbation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ def _apply_perturbation(
ds_slice_copy = ds_slice.copy()

# Apply the transformation
if col_type == SupportedPerturbationType.NUMERIC:
if col_type == SupportedPerturbationType.NUMERIC and ds.df.dtypes[feature] in ["int64", "float64"]:
Copy link
Contributor

@rabah-khalek rabah-khalek May 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about int32, float32, etc.?

I think this https://pandas.pydata.org/docs/reference/api/pandas.api.types.is_datetime64_any_dtype.html would be better

Copy link
Member Author

@kevinmessiaen kevinmessiaen May 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up using https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.api.types.is_any_real_numeric_dtype.html which is more robust.

As it will exclude all non-real numeric data type so we don't end up with the same issue with another pseudo-numeric data type.

passed = _numeric(
ds,
ds_slice,
Expand Down