Skip to content

Conversation

@Hartorn
Copy link
Member

@Hartorn Hartorn commented Mar 13, 2024

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@Hartorn Hartorn requested a review from rabah-khalek March 13, 2024 16:54
@Hartorn Hartorn self-assigned this Mar 13, 2024
@linear
Copy link

linear bot commented Mar 13, 2024

Copy link
Contributor

@rabah-khalek rabah-khalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a pass to me, I tested it with: https://colab.research.google.com/drive/1vcTR2SSfdO-VbqlkaEmZqViNyLuyEN2y?usp=sharing it works.

Let's make sure @kevinmessiaen approves as well. I'm 99% sure it won't break anything on the hub.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

@rabah-khalek rabah-khalek marked this pull request as ready for review March 14, 2024 07:44
@Hartorn
Copy link
Member Author

Hartorn commented Mar 14, 2024

@rabah-khalek Thanks for fixing the doc string !

@Hartorn Hartorn merged commit 6fc9458 into main Mar 14, 2024
@Hartorn Hartorn deleted the feature/gsk-3303-issue-with-pydantic-v1 branch March 14, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants