Skip to content

Conversation

@vjern
Copy link
Contributor

@vjern vjern commented Feb 20, 2024

Description

In order to only have the light theme logo display in PyPI, we simply remove the dark theme logo img tag from the README as we build the release candidate wheel (which eventually gets published to PyPI in the current release flow).

(Assuming PyPI looks in the wheel rather than the tarball when fetching the package's description. Otherwise, we would rather make the edit in post-release.yml).

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@linear
Copy link

linear bot commented Feb 20, 2024

@vjern vjern marked this pull request as ready for review February 20, 2024 10:31
@vjern vjern requested a review from a team February 20, 2024 10:31
@vjern vjern changed the title [GSK-2834] Remove README dark theme logo in RC wheel [GSK-2834] Show only light theme logo in PyPI package description Feb 20, 2024
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@kevinmessiaen kevinmessiaen merged commit 661dd3c into main Feb 21, 2024
@kevinmessiaen kevinmessiaen deleted the feature/gsk-2834-handle-black-logo-in-pypi branch February 21, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants