GSK-2819 Pydantic models cannot be serialised with our code #1808
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Description
Issue
By default we try to serialise models by value using cloudpickle in order to be able to execute them in ML Worker without having to install the referenced dependency. However cloudpickle is not able to serialise everything causing the serialisation to fail.
Solution
For complex code that aren't pickable, it's always possible to save the code in a module and install it into the ML worker. Therefore when cloudpickle fail to save objects by value, we fallback into saving by reference with a warning.
Related Issue
Type of Change