- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 377
[GSK 2658] Custom scanner #1763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Could you please also add on this branch a way to disable the "warning" and "Debug your issues in the Giskard hub" parts from the HTML templates? | 
…rd into GSK-2658-custom-scanner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few typing comments remaining, otherwise it's good.
you pushed by mistake memory_fixtures.csv and memory_tests.csv, could you please remove these?
| description: str | ||
|  | ||
|  | ||
| class ScanExamples(ABC): | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we using naming with s for plural elsewhere ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is used to manage several examples at once, so I guess the plural is better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Miss click
| 
 | 

Description
Add an example manager to deal with new data types in the scan report. The example manager should be able to add examples and render html code to be integrated into the report.
Related Issue
Type of Change
Checklist
CODE_OF_CONDUCT.mddocument.CONTRIBUTING.mdguide.make codestyle.