[GSK-2378] Only persist/read cache when explicitly asked #1680
Conversation
kevinmessiaen
requested review from
Hartorn,
Inokinoki,
andreybavt and
mattbit
and removed request for
Hartorn and
mattbit
…el-cache-button-in-the-hub' into feature/gsk-2378-add-a-clear-model-cache-button-in-the-hub
| ) -> websocket.TestSuite: | ||
| log_listener = LogListener() | ||
|
|
||
| loaded_artifacts = dict() |
There was a problem hiding this comment.
Why is it initialized here if it's also set in the function with the 'if none' condition ?
There was a problem hiding this comment.
it' done to share the cache between the global arguments and test ones
Hartorn
left a comment
Hartorn
left a comment
There was a problem hiding this comment.
Looks good, some small comment.
Did not test , and just looked quickly
giskard/ml_worker/websocket/utils.py
Outdated
| def parse_function_arguments(client: Optional[GiskardClient], request_arguments: List[websocket.FuncArgument]): | ||
| def _get_or_load(loaded_artifacts: Dict[str, Dict[str, Any]], type: str, uuid: str, load_fn: Callable[[], Any]) -> Any: | ||
| if type not in loaded_artifacts: | ||
| loaded_artifacts[type] = dict() |
There was a problem hiding this comment.
This could be avoided by giving a defaultdict instead of a dict, with dict as default factory
| ) -> websocket.TestSuite: | ||
| log_listener = LogListener() | ||
|
|
||
| loaded_artifacts = dict() |
There was a problem hiding this comment.
it' done to share the cache between the global arguments and test ones
giskard/models/cache/cache.py
Outdated
| cache_dir = self._default_cache_dir_prefix.joinpath(self.id) | ||
| if persist_cache: | ||
| if cache_dir is None and self.id: | ||
| cache_dir = self._default_cache_dir_prefix.joinpath(self.id) |
There was a problem hiding this comment.
Could be self._default_cache_dir_prefix / self.id
Hartorn
changed the title
|
Hartorn
deleted the
feature/gsk-2378-add-a-clear-model-cache-button-in-the-hub
branch
Description
Related Issue
Type of Change
Checklist
CODE_OF_CONDUCT.mddocument.CONTRIBUTING.mdguide.make codestyle.