Skip to content

[GSK-2294] Fix doc for slicing and transformations #1670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2023
Merged

[GSK-2294] Fix doc for slicing and transformations #1670

merged 1 commit into from
Dec 7, 2023

Conversation

@Hartorn
Copy link
Member

@Hartorn Hartorn commented Dec 6, 2023 •
edited
Loading

Description

See also https://github.com/Giskard-AI/giskard-hub/pull/283

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@Hartorn Hartorn added the bug Something isn't working label Dec 6, 2023
@Hartorn Hartorn self-assigned this Dec 6, 2023
@linear
Copy link

linear bot commented Dec 6, 2023

GSK-2294 Impossible to delete a rule based slicing function

@Hartorn Hartorn force-pushed the feature/gsk-2294-impossible-to-delete-a-rule-based-slicing-function branch from 4543583 to 696a306 Compare December 6, 2023 16:43
@Hartorn Hartorn marked this pull request as ready for review December 6, 2023 16:44
@kevinmessiaen kevinmessiaen self-assigned this Dec 6, 2023
@Hartorn Hartorn changed the title Fix doc for slicing and transformations [GSK-2294] Fix doc for slicing and transformations Dec 6, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

kevinmessiaen
kevinmessiaen approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@kevinmessiaen kevinmessiaen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinmessiaen kevinmessiaen merged commit 56543d9 into main Dec 7, 2023
@kevinmessiaen kevinmessiaen deleted the feature/gsk-2294-impossible-to-delete-a-rule-based-slicing-function branch December 7, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinmessiaen kevinmessiaen kevinmessiaen approved these changes

@andreybavt andreybavt Awaiting requested review from andreybavt

Assignees

@Hartorn Hartorn

@kevinmessiaen kevinmessiaen

Labels

bug Something isn't working

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Hartorn @kevinmessiaen