Skip to content

[GSK-2323] Set content-type to json actively for dumped str #1662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2023
Merged

[GSK-2323] Set content-type to json actively for dumped str #1662

merged 1 commit into from
Dec 6, 2023

Conversation

@Inokinoki
Copy link
Member

@Inokinoki Inokinoki commented Dec 5, 2023 •
edited
Loading

Description

To addres the issue introduced by GSK-2184, actively set content-type to "application/json".

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@linear
Copy link

linear bot commented Dec 5, 2023

GSK-2323 Save meta does not work due to wrong content-type

@Inokinoki Inokinoki self-assigned this Dec 5, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@kevinmessiaen kevinmessiaen merged commit 1f86908 into main Dec 6, 2023
@kevinmessiaen kevinmessiaen deleted the feature/gsk-2323-save-meta-does-not-work-due-to-wrong-content-type branch December 6, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinmessiaen kevinmessiaen kevinmessiaen approved these changes

Assignees

@Inokinoki Inokinoki

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Inokinoki @kevinmessiaen