[GSK-2292 GSK-2293] Add args kwargs to the public methods of the model and all

[kevinmessiaen]

Description

• Add args and kwargs to the public methods of the model class and subclass
• Add backward compatibility tests

Type of Change

• 📚 Examples / docs / tutorials / dependencies update
• 🔧 Bug fix (non-breaking change which fixes an issue)
• 🥂 Improvement (non-breaking change which improves an existing feature)
• 🚀 New feature (non-breaking change which adds functionality)
• 💥 Breaking change (fix or feature that would cause existing functionality to change)
• 🔐 Security fix

[linear]

GSK-2293 Add a test to make sure that the IPCC model is loadable and works

GSK-2292 add `*args, **kwargs` to the public methods of the Model and all it's child classes

[Inokinoki]

How do we ensure the backward compatibility here?

[kevinmessiaen]

This one is a lookup table (which pickled version to open), I haven't pickled in Python 3.9 so 3.9 opens 3.10 pickle.

The real test is can we still load the model and predict and we will get an error if we break it by modifying the model class

[Inokinoki]

LGTM!

My only concern is on the unused args and kwargs, which impacts the code smell.
But I think we have to do it if without a better solution...

[kevinmessiaen]

LGTM!

My only concern is on the unused args and kwargs, which impacts the code smell. But I think we have to do it if without a better solution...

Let me change to def method(..., *_args, **_kwargs) to prevent code smells

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication