Skip to content

Fixed bug making it impossible to create giskard client #1650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 1, 2023
Merged

Fixed bug making it impossible to create giskard client #1650

merged 2 commits into from
Dec 1, 2023

Conversation

@kevinmessiaen
Copy link
Member

@kevinmessiaen kevinmessiaen commented Dec 1, 2023

Description

Fixed bug making it impossible to create giskard client

Related Issue

GSK-2281

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

@kevinmessiaen kevinmessiaen requested a review from cy-moi December 1, 2023 09:09
@linear
Copy link

linear bot commented Dec 1, 2023

GSK-2281 'Response' object has no attribute 'status'

@kevinmessiaen kevinmessiaen marked this pull request as ready for review December 1, 2023 09:25
@kevinmessiaen kevinmessiaen assigned Inokinoki and unassigned Inokinoki Dec 1, 2023
@kevinmessiaen kevinmessiaen added bug Something isn't working High priority Created by Linear-GitHub Sync labels Dec 1, 2023
Googleton
Googleton approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@Googleton Googleton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

@kevinmessiaen kevinmessiaen merged commit eacf946 into main Dec 1, 2023
@kevinmessiaen kevinmessiaen deleted the feature/gsk-2281-response-object-has-no-attribute-status branch December 1, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cy-moi cy-moi Awaiting requested review from cy-moi

@Inokinoki Inokinoki Awaiting requested review from Inokinoki

@Hartorn Hartorn Awaiting requested review from Hartorn

@andreybavt andreybavt Awaiting requested review from andreybavt

1 more reviewer

@Googleton Googleton Googleton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working High priority Created by Linear-GitHub Sync

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kevinmessiaen @Googleton @Inokinoki