Skip to content

Remove protobuf #1649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 2, 2023
Merged

Remove protobuf #1649

merged 3 commits into from
Dec 2, 2023

Conversation

@Hartorn
Copy link
Member

@Hartorn Hartorn commented Nov 30, 2023

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@Hartorn Hartorn added the Lockfile Temporary label to update pdm.lock label Nov 30, 2023
@Hartorn Hartorn self-assigned this Nov 30, 2023
@github-actions github-actions bot removed the Lockfile Temporary label to update pdm.lock label Nov 30, 2023
@Hartorn
Copy link
Member Author

Hartorn commented Nov 30, 2023 •
edited
Loading

Testing with protobuf 4.25.1
https://github.com/Giskard-AI/giskard/actions/runs/7049398784

@Hartorn Hartorn marked this pull request as ready for review December 1, 2023 13:27
@Hartorn
Copy link
Member Author

Hartorn commented Dec 1, 2023

Tested locally, working fine

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

rabah-khalek
rabah-khalek approved these changes Dec 2, 2023
View reviewed changes
Copy link
Contributor

@rabah-khalek rabah-khalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's great!

@rabah-khalek rabah-khalek merged commit bbab8ed into main Dec 2, 2023
@rabah-khalek rabah-khalek deleted the remove-protobuf branch December 2, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreybavt andreybavt Awaiting requested review from andreybavt

1 more reviewer

@rabah-khalek rabah-khalek rabah-khalek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Hartorn Hartorn

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Hartorn @rabah-khalek