Skip to content

Only scan a subset of features [GSK-2173] #1635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 24, 2023
Merged

Only scan a subset of features [GSK-2173] #1635

merged 10 commits into from
Nov 24, 2023

Conversation

@mattbit
Copy link
Member

@mattbit mattbit commented Nov 24, 2023

The Giskard scan can now be limited to an arbitrary subset of features:

import giskard as gsk
...
report = gsk.scan(model, dataset, features=["feature_1", "feature_2"])

@linear
Copy link

linear bot commented Nov 24, 2023

GSK-2173 Limit scanned features

Case: I have big dataset with lots of features but I want to run the scan only on a small selection of them.

@mattbit mattbit marked this pull request as ready for review November 24, 2023 11:22
@kevinmessiaen kevinmessiaen self-assigned this Nov 24, 2023
kevinmessiaen
kevinmessiaen approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@kevinmessiaen kevinmessiaen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@mattbit mattbit added enhancement New feature or request Improvement Created by Linear-GitHub Sync scan Created by Linear-GitHub Sync labels Nov 24, 2023
@mattbit mattbit enabled auto-merge November 24, 2023 13:32
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

97.7% 97.7% Coverage
1.3% 1.3% Duplication

@mattbit mattbit merged commit c74205e into main Nov 24, 2023
@mattbit mattbit deleted the task/limit-scan-features branch November 24, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinmessiaen kevinmessiaen kevinmessiaen approved these changes

Assignees

@kevinmessiaen kevinmessiaen

Labels

enhancement New feature or request Improvement Created by Linear-GitHub Sync scan Created by Linear-GitHub Sync

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mattbit @kevinmessiaen