Skip to content

[GSK-2032] Fix debug master #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 31, 2023
Merged

[GSK-2032] Fix debug master #1534

merged 6 commits into from
Oct 31, 2023

Conversation

@Hartorn
Copy link
Member

@Hartorn Hartorn commented Oct 31, 2023

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@Hartorn Hartorn requested a review from andreybavt October 31, 2023 18:35
@Hartorn Hartorn self-assigned this Oct 31, 2023
@linear
Copy link

linear bot commented Oct 31, 2023

GSK-2032 Debug feature for LLM is not working because missing kwargs test input

To reproduce, debug one of the test from this test suite: https://demo.giskard.ai/main/projects/203/testing/352/overview

image.png

@Hartorn Hartorn force-pushed the fix-debug-master branch 2 times, most recently from cc76d82 to b0d9bd8 Compare October 31, 2023 18:38
@andreybavt
fix extract_parameters
18d53c9
@andreybavt
Merge pull request #1508 from Giskard-AI/feature/gsk-1914-cta-push-te…
d738c99 
…st-slicing-f1-difference-is-putting-a-kwarg-as

[GSK-1914] Made kwargs default value persistent in the Hub
@andreybavt andreybavt merged commit 2681a3d into main Oct 31, 2023
@andreybavt andreybavt deleted the fix-debug-master branch October 31, 2023 21:40
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

82.0% 82.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@andreybavt andreybavt andreybavt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Hartorn Hartorn

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Hartorn @andreybavt @kevinmessiaen