Skip to content

Threshold for performance test for regression #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 13, 2022
Merged

Threshold for performance test for regression #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcf9db2
Change threshold from 0.7 to 10 for regression
jmsquare Jul 12, 2022
09d4c05
From 0.7 to 10 for MAE and RMSE
jmsquare Jul 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions giskard-ml-worker/ml_worker/testing/performance_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ def test_rmse(self, actual_slice, model: GiskardModel, threshold=1):
"""
Test if the model RMSE is lower than a threshold

Example: The test is passed when the RMSE is lower than 0.7
Example: The test is passed when the RMSE is lower than 10

Args:
actual_slice(GiskardDataset):
Expand All @@ -226,7 +226,7 @@ def test_mae(self, actual_slice, model: GiskardModel, threshold=1):
"""
Test if the model Mean Absolute Error is lower than a threshold

Example: The test is passed when the MAE is lower than 0.7
Example: The test is passed when the MAE is lower than 10

Args:
actual_slice(GiskardDataset):
Expand Down
8 changes: 4 additions & 4 deletions giskard-server/src/main/resources/aitest/code_test_templates/performance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,7 +478,7 @@ items:

Description: Test if the model RMSE is lower than a threshold

Example: The test is passed when the RMSE is lower than 0.7
Example: The test is passed when the RMSE is lower than 10

Args:
actual_slice(GiskardDataset):
Expand All @@ -500,7 +500,7 @@ items:
tests.performance.test_rmse(
actual_slice=actual_ds.slice(lambda df: df.head(len(df) // 2)),
model=model,
threshold=0.7
threshold=10
)
- id: diff_rmse
title: RMSE difference
Expand Down Expand Up @@ -602,7 +602,7 @@ items:

Description: Test if the model Mean Absolute Error is lower than a threshold

Example: The test is passed when the MAE is lower than 0.7
Example: The test is passed when the MAE is lower than 10

Args:
actual_slice(GiskardDataset):
Expand All @@ -623,7 +623,7 @@ items:
tests.performance.test_mae(
actual_slice=actual_ds.slice(lambda df: df.head(len(df) // 2)),
model=model,
threshold=0.7
threshold=10
)
- id: r2
title: R2
Expand Down