Skip to content

[GSK-1608] Replace 'token' with 'key' when instantiating GiskardClient on demo notebooks #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 30, 2023
Merged

[GSK-1608] Replace 'token' with 'key' when instantiating GiskardClient on demo notebooks #1520

merged 4 commits into from
Oct 30, 2023

Conversation

@henchaves
Copy link
Member

@henchaves henchaves commented Oct 30, 2023

Description

Update remaining notebooks to make Giskard CLI arguments uniform.

Related Issue

GSK-1608 (available on Linear)

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

@henchaves henchaves self-assigned this Oct 30, 2023
@linear
Copy link

linear bot commented Oct 30, 2023

GSK-1608 Make token names and cli arguments uniform

HuggingFace Token as --hf-token
Ngrok API Token as --ngrok-token

Don't use the CLI short argument -t to any third party token.

Update docs and notebooks

@henchaves henchaves requested a review from Inokinoki October 30, 2023 08:19
@henchaves henchaves added the documentation Improvements or additions to documentation label Oct 30, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Inokinoki
Inokinoki reviewed Oct 30, 2023
View reviewed changes
Copy link
Member

@Inokinoki Inokinoki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general!

There are too many unrelated changes though, due to the Jupyter notebook save across versions. Most of them are re-ordering.

Could we improve the commit messages (or the PR title)? The others could know quickly which parts are updated.

@henchaves henchaves changed the title [GSK-1608] Make token names and cli arguments uniform [GSK-1608] Replace 'token' with 'key' when instantiating GiskardClient on demo notebooks Oct 30, 2023
@henchaves henchaves requested a review from Inokinoki October 30, 2023 12:57
@Inokinoki Inokinoki merged commit eefddae into main Oct 30, 2023
@Inokinoki Inokinoki deleted the fix/giskard-cli-params branch October 30, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Inokinoki Inokinoki Inokinoki approved these changes

Assignees

@henchaves henchaves

Labels

documentation Improvements or additions to documentation

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@henchaves @Inokinoki