Skip to content

Fix pip CI job #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2023
Merged

Fix pip CI job #1519

merged 1 commit into from
Oct 28, 2023
+6 −6

Conversation

@mattbit
Copy link
Member

@mattbit mattbit commented Oct 27, 2023 •
edited
Loading

PDM does not provide pip by default, so the system pip was erroneusly used. Standard library venv does instead add pip to the environment.

@mattbit mattbit requested a review from Hartorn October 27, 2023 18:35
@mattbit mattbit marked this pull request as ready for review October 27, 2023 18:35
@mattbit mattbit requested a review from a team October 27, 2023 18:35
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@andreybavt andreybavt merged commit dd1c843 into main Oct 28, 2023
@andreybavt andreybavt deleted the task/fix-pip-ci branch October 28, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hartorn Hartorn Awaiting requested review from Hartorn

1 more reviewer

@andreybavt andreybavt andreybavt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mattbit @andreybavt