[GSK-1978,GSK-1965] LLM scan consolidation #1513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbit
changed the title
|
GSK-1978 Add unit tests for LLM scan GSK-1965 Standardized config of internal LLM usage
In particular what is used in internal LLM utils |
2 tasks
rabah-khalek
approved these changes
Oct 30, 2023
Comment on lines
+113
to
+116
| if out.function_call.args["passed_test"]: | ||
| results.append(EvalTestResult(score=5, reason="The answer is correct")) | ||
| else: | ||
| results.append(EvalTestResult(score=0, reason=out.function_call.args.get("reason"))) |
There was a problem hiding this comment.
clarification: so this 3 indicates that the answer can be improved currently never happens?
There was a problem hiding this comment.
This code is legacy and will be removed soon.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few fixes and tests for the LLM scan.
prompt_injection