Skip to content

Conversation

@Hartorn
Copy link
Member

@Hartorn Hartorn commented Oct 26, 2023

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@Hartorn Hartorn added the bug Something isn't working label Oct 26, 2023
@Hartorn Hartorn requested a review from mattbit October 26, 2023 12:25
@Hartorn Hartorn self-assigned this Oct 26, 2023
@Hartorn Hartorn force-pushed the bugfix/sonar-coverage branch from 216b9f4 to 2c7824e Compare October 26, 2023 12:47
@mattbit
Copy link
Member

mattbit commented Oct 26, 2023

@Hartorn

Last analysis has warnings
The following error(s) occurred while trying to import coverage report:
Invalid directory path in 'source' element: /home/runner/work/giskard/giskard/giskard
Cannot resolve 149 file paths, ignoring coverage measures for those files
Cannot resolve the file path 'init.py' of the coverage report, the file does not exist in all 'source'.

@Hartorn Hartorn force-pushed the bugfix/sonar-coverage branch from 2c7824e to 8cf8a46 Compare October 26, 2023 13:35
Base automatically changed from bugfix/avoid-multiple-upload to main October 26, 2023 13:38
Copy link
Member

@mattbit mattbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think modifications of suite.py were erroneously included.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this is here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's because of main was updated with some stuff, I get some conflict

@Hartorn Hartorn force-pushed the bugfix/sonar-coverage branch from 8cf8a46 to 928c278 Compare October 26, 2023 14:30
@Hartorn Hartorn marked this pull request as ready for review October 26, 2023 14:30
@Hartorn Hartorn requested a review from a team October 26, 2023 14:30
@Hartorn
Copy link
Member Author

Hartorn commented Oct 26, 2023

@mattbit did you get notified before with PR was not in draft anymore ? or did you saw it in pull requests ?

@mattbit mattbit merged commit 3ff7f72 into main Oct 26, 2023
@mattbit mattbit deleted the bugfix/sonar-coverage branch October 26, 2023 14:37
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Development

Successfully merging this pull request may close these issues.

3 participants