Skip to content

Rename server to hub #1509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 3, 2023
Merged

Rename server to hub #1509

merged 6 commits into from
Nov 3, 2023

Conversation

@Hartorn
Copy link
Member

@Hartorn Hartorn commented Oct 26, 2023 •
edited
Loading

Description

Needs #1506 to be merged before
See also https://github.com/Giskard-AI/giskard-hub/pull/185

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@Hartorn Hartorn added the Lockfile Temporary label to update pdm.lock label Oct 26, 2023
@Hartorn Hartorn self-assigned this Oct 26, 2023
@linear
Copy link

linear bot commented Oct 26, 2023

GSK-1746 Rename "server" pdm dependency group to "hub"

@Hartorn Hartorn added Lockfile Temporary label to update pdm.lock and removed Lockfile Temporary label to update pdm.lock labels Oct 26, 2023
@github-actions github-actions bot removed the Lockfile Temporary label to update pdm.lock label Oct 26, 2023
@Hartorn Hartorn marked this pull request as ready for review October 26, 2023 10:52
@Hartorn Hartorn requested a review from a team October 26, 2023 10:52
Base automatically changed from handle-lock to main October 27, 2023 17:12
Inokinoki
Inokinoki requested changes Oct 31, 2023
View reviewed changes
Copy link
Member

@Inokinoki Inokinoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general.

There are some conflicts with main

@Hartorn Hartorn force-pushed the feature/gsk-1746-rename-server-pdm-dependency-group-to-hub branch from 33fb7e1 to 6f528ce Compare October 31, 2023 13:18
@Hartorn Hartorn added the Lockfile Temporary label to update pdm.lock label Oct 31, 2023
@github-actions github-actions bot removed the Lockfile Temporary label to update pdm.lock label Oct 31, 2023
Inokinoki
Inokinoki reviewed Nov 1, 2023
View reviewed changes
giskard/commands/cli_hub.py
Copy link
Member

@Inokinoki Inokinoki Nov 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a # noqa on endpoint = f"http://{host}:{port}/management/health"

@Hartorn Hartorn force-pushed the feature/gsk-1746-rename-server-pdm-dependency-group-to-hub branch from afb288b to 4fee79d Compare November 3, 2023 14:04
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 3, 2023 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

1.0% 1.0% Coverage
0.0% 0.0% Duplication

@andreybavt andreybavt merged commit d2fdd1f into main Nov 3, 2023
@andreybavt andreybavt deleted the feature/gsk-1746-rename-server-pdm-dependency-group-to-hub branch November 3, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Inokinoki Inokinoki Inokinoki requested changes

+1 more reviewer

@andreybavt andreybavt andreybavt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Hartorn Hartorn

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Hartorn @andreybavt @Inokinoki