Skip to content

[GSK-1891][GSK-1967] W&B related updates #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 27, 2023
Merged

[GSK-1891][GSK-1967] W&B related updates #1505

merged 14 commits into from
Oct 27, 2023

Conversation

@rabah-khalek
Copy link
Contributor

@rabah-khalek rabah-khalek commented Oct 25, 2023 •
edited
Loading

  • Removing the internal run initiation (including the feedback I got from Thomas).
  • Improving the docs + notebook (including the feedback I got from Thomas).
  • Adding LLM notebook to the doc

@linear
Copy link

linear bot commented Oct 25, 2023

GSK-1967 Implement Thomas's feedback (wandb)

feedback:

  • remove:
wandb login --relogin # input the API key you get from the website
wandb server start --upgrade # this will download the docker images if they're not already downloaded
  • expose the wandb run to the user
  • Try out: wandb.autolog

@rabah-khalek rabah-khalek marked this pull request as draft October 25, 2023 12:31
@rabah-khalek rabah-khalek self-assigned this Oct 26, 2023
@rabah-khalek rabah-khalek added documentation Improvements or additions to documentation Python Pull requests that update Python code Integrations labels Oct 26, 2023
@rabah-khalek rabah-khalek changed the title [GSK-1967] W&B related updates [GSK-1891][GSK-1967] W&B related updates Oct 26, 2023
@linear
Copy link

linear bot commented Oct 26, 2023

GSK-1891 W&B article

https://www.notion.so/giskard/Meeting-10-10-2eced87184534fb491787c4de0fcbf21?pvs=4

@rabah-khalek rabah-khalek marked this pull request as ready for review October 26, 2023 23:26
@rabah-khalek rabah-khalek requested a review from mattbit October 27, 2023 09:43
mattbit
mattbit reviewed Oct 27, 2023
View reviewed changes
Copy link
Member

@mattbit mattbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments

luca-martial
luca-martial approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@luca-martial luca-martial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs LGTM

@rabah-khalek rabah-khalek requested a review from mattbit October 27, 2023 10:52
mattbit
mattbit approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@mattbit mattbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing some Optional[...] in the type hints but otherwise good for me! Well done @rabah-khalek

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

70.0% 70.0% Coverage
0.0% 0.0% Duplication

@rabah-khalek rabah-khalek merged commit 47a5df3 into main Oct 27, 2023
@rabah-khalek rabah-khalek deleted the GSK-1967-wandb-update branch October 27, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattbit mattbit mattbit approved these changes

+1 more reviewer

@luca-martial luca-martial luca-martial approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rabah-khalek rabah-khalek

Labels

documentation Improvements or additions to documentation Integrations Python Pull requests that update Python code

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rabah-khalek @mattbit @luca-martial