GSK-1963: ignore mixpanel errors

giskard/utils/analytics_collector.py

@@ -4,11 +4,11 @@
 import platform
 import sys
 import threading
-from traceback import TracebackException
-from types import TracebackType
 import uuid
 from functools import wraps
 from threading import ExceptHookArgs, Lock
+from traceback import TracebackException
+from types import TracebackType
 from typing import Dict, Optional, Type
 
 import requests
@@ -31,11 +31,8 @@ def inner_function(*args, **kwargs):
 
         try:
             return f(*args, **kwargs)
-        except BaseException as e:  # NOSONAR
-            try:
-                _report_error(e, error_type="tracking error")
-            except BaseException:  # NOSONAR
-                pass
+        except BaseException:  # NOSONAR
+            pass
 
     return inner_function
 
@@ -149,6 +146,7 @@ def track(self, event_name, properties=None, meta=None, force=False):
         return self._track(event_name, properties=properties, meta=meta, force=force)
 
     @threaded
+    @analytics_method
     def _track(self, event_name, properties=None, meta=None, force=False):
         self.initialize_giskard_version()
         self.initialize_user_properties()

tests/communications/test_analytics_collector.py

@@ -0,0 +1,9 @@
+from mixpanel import Consumer
+
+from utils.analytics_collector import GiskardAnalyticsCollector
+
+
+def test_tracking_doesnt_throw_errors():
+    ac = GiskardAnalyticsCollector()
+    ac.mp._consumer = Consumer(events_url="https://invalid.url")
+    ac.track("test")