Skip to content

Conversation

@Hartorn
Copy link
Member

@Hartorn Hartorn commented Oct 23, 2023

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@linear
Copy link

linear bot commented Oct 23, 2023

GSK-1947 TypeError while running the scan

I encountered several time this error while running the scan:

---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
File /usr/local/Caskroom/miniconda/base/lib/python3.10/threading.py:1326, in _make_invoke_excepthook.<locals>.invoke_excepthook(thread)
   1322         hook = old_excepthook
   1324     args = ExceptHookArgs([*sys_exc_info(), thread])
-> 1326     hook(args)
   1327 except Exception as exc:
   1328     exc.__suppress_context__ = True

TypeError: add_exception_hook.<locals>._exception_hook() missing 2 required positional arguments: 'value' and 'traceback'

Does it look familiar? is it related to the analytics collector?
There're no additional logs unfortunately.

Assigned to bazire based on a suggestion from mattbit

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mattbit
Copy link
Member

mattbit commented Oct 24, 2023

Once this is merged, we should also check why it gets called. @andreybavt could you check the exception logs in the next couple of days?

Copy link
Contributor

@rabah-khalek rabah-khalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested it locally with the llm-scan from feature/llm-scan.

@mattbit mattbit merged commit 0a8c342 into main Oct 24, 2023
@mattbit mattbit deleted the feature/gsk-1947-typeerror-while-running-the-scan branch October 24, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants