Added default value for clauses to match backend DTO #1483

kevinmessiaen · 2023-10-19T02:26:11Z

Description

Added default value for clauses to match backend DTO

Related Issue

GSK-1908

Type of Change

📚 Examples / docs / tutorials / dependencies update
🔧 Bug fix (non-breaking change which fixes an issue)
🥂 Improvement (non-breaking change which improves an existing feature)
🚀 New feature (non-breaking change which adds functionality)
💥 Breaking change (fix or feature that would cause existing functionality to change)
🔐 Security fix

linear · 2023-10-19T02:26:14Z

GSK-1908 Titanic demo snippet breaks at test suite upload

Tested on python 3.11

create new project
execute the titanic code snippet

Your model is successfully validated.
Model successfully uploaded to project key 'test2' with ID = 9e2fb411-2408-4e57-bee0-3189a230ea30
Dataset successfully uploaded to project key 'test2' with ID = cf2dd093-e22a-4434-b7ee-bb8736940f86
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/private/tmp/.venv/lib/python3.11/site-packages/giskard/core/suite.py", line 420, in upload
    self.id = client.save_test_suite(self.to_dto(client, project_key))
                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/private/tmp/.venv/lib/python3.11/site-packages/giskard/core/suite.py", line 435, in to_dto
    functionInputs={
                   ^
  File "/private/tmp/.venv/lib/python3.11/site-packages/giskard/core/suite.py", line 436, in <dictcomp>
    pname: build_test_input_dto(
           ^^^^^^^^^^^^^^^^^^^^^
  File "/private/tmp/.venv/lib/python3.11/site-packages/giskard/core/suite.py", line 256, in build_test_input_dto
    p.upload(client, None if "giskard" in p.meta.tags else project_key)
  File "/private/tmp/.venv/lib/python3.11/site-packages/giskard/ml_worker/core/savable.py", line 91, in upload
    self.meta = client.save_meta(self._get_meta_endpoint(self.meta.uuid, project_key), self.meta)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/private/tmp/.venv/lib/python3.11/site-packages/giskard/client/giskard_client.py", line 309, in save_meta
    json = self._session.put(endpoint, json=meta.to_json()).json()
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/private/tmp/.venv/lib/python3.11/site-packages/requests/sessions.py", line 649, in put
    return self.request("PUT", url, data=data, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/private/tmp/.venv/lib/python3.11/site-packages/requests_toolbelt/sessions.py", line 76, in request
    return super(BaseUrlSession, self).request(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/private/tmp/.venv/lib/python3.11/site-packages/requests/sessions.py", line 589, in request
    resp = self.send(prep, **send_kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/private/tmp/.venv/lib/python3.11/site-packages/requests/sessions.py", line 703, in send
    r = adapter.send(request, **kwargs)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/private/tmp/.venv/lib/python3.11/site-packages/requests/adapters.py", line 538, in send
    return self.build_response(request, resp)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/private/tmp/.venv/lib/python3.11/site-packages/giskard/client/giskard_client.py", line 60, in build_response
    raise giskard_error
giskard.client.giskard_client.GiskardError: Bad Request: Invalid request content.