Feature/gsk 1847 enron model test suite cannot be run #1458

Hartorn · 2023-10-05T10:48:21Z

Description

Related Issue

Type of Change

📚 Examples / docs / tutorials / dependencies update
🔧 Bug fix (non-breaking change which fixes an issue)
🥂 Improvement (non-breaking change which improves an existing feature)
🚀 New feature (non-breaking change which adds functionality)
💥 Breaking change (fix or feature that would cause existing functionality to change)
🔐 Security fix

Checklist

I've read the CODE_OF_CONDUCT.md document.
I've read the CONTRIBUTING.md guide.
I've updated the code style using make codestyle.
I've written tests for all new methods and classes that I created.
I've written the docstring in Google format for all the methods and classes that I used.

linear · 2023-10-05T10:48:24Z

GSK-1847 Enron model test suite cannot be run

After running the notebook, I tried to run the tes suite inside the project, but it does not work.

image.png

2023-10-04 12:06:53,989 INFO Artifact enron/models/a3ddd357-1b4e-4935-a7c3-530062481332 already exists, skipping download
2023-10-04 12:06:54,006 INFO Artifact enron/datasets/e8e9483a-327d-432d-abd4-d1ddd4056943 already exists, skipping download
2023-10-04 12:06:54,064 INFO Casting dataframe columns from {'Content': 'object', 'Target': 'object'} to {'Content': 'object', 'Target': 'object'}
2023-10-04 12:06:54,077 INFO Your 'pandas.DataFrame' is successfully wrapped by Giskard's 'Dataset' wrapper class.
2023-10-04 12:06:54,088 INFO Artifact enron/models/a3ddd357-1b4e-4935-a7c3-530062481332 already exists, skipping download
2023-10-04 12:06:54,102 INFO Artifact enron/datasets/e8e9483a-327d-432d-abd4-d1ddd4056943 already exists, skipping download
2023-10-04 12:06:54,157 INFO Casting dataframe columns from {'Content': 'object', 'Target': 'object'} to {'Content': 'object', 'Target': 'object'}
2023-10-04 12:06:54,170 INFO Your 'pandas.DataFrame' is successfully wrapped by Giskard's 'Dataset' wrapper class.
2023-10-04 12:06:54,179 INFO Artifact enron/models/a3ddd357-1b4e-4935-a7c3-530062481332 already exists, skipping download
2023-10-04 12:06:54,190 INFO Artifact enron/datasets/e8e9483a-327d-432d-abd4-d1ddd4056943 already exists, skipping download
2023-10-04 12:06:54,243 INFO Casting dataframe columns from {'Content': 'object', 'Target': 'object'} to {'Content': 'object', 'Target': 'object'}
2023-10-04 12:06:54,255 INFO Your 'pandas.DataFrame' is successfully wrapped by Giskard's 'Dataset' wrapper class.
2023-10-04 12:06:54,265 INFO Artifact enron/models/a3ddd357-1b4e-4935-a7c3-530062481332 already exists, skipping download
2023-10-04 12:06:54,277 INFO Artifact enron/datasets/e8e9483a-327d-432d-abd4-d1ddd4056943 already exists, skipping download
2023-10-04 12:06:54,356 INFO Casting dataframe columns from {'Content': 'object', 'Target': 'object'} to {'Content': 'object', 'Target': 'object'}
2023-10-04 12:06:54,368 INFO Your 'pandas.DataFrame' is successfully wrapped by Giskard's 'Dataset' wrapper class.
2023-10-04 12:06:54,377 INFO Artifact enron/models/a3ddd357-1b4e-4935-a7c3-530062481332 already exists, skipping download
2023-10-04 12:06:54,388 INFO Artifact enron/datasets/e8e9483a-327d-432d-abd4-d1ddd4056943 already exists, skipping download
2023-10-04 12:06:54,443 INFO Casting dataframe columns from {'Content': 'object', 'Target': 'object'} to {'Content': 'object', 'Target': 'object'}
2023-10-04 12:06:54,454 INFO Your 'pandas.DataFrame' is successfully wrapped by Giskard's 'Dataset' wrapper class.
2023-10-04 12:06:54,463 INFO Artifact enron/models/a3ddd357-1b4e-4935-a7c3-530062481332 already exists, skipping download
2023-10-04 12:06:54,476 INFO Artifact enron/datasets/e8e9483a-327d-432d-abd4-d1ddd4056943 already exists, skipping download
2023-10-04 12:06:54,528 INFO Casting dataframe columns from {'Content': 'object', 'Target': 'object'} to {'Content': 'object', 'Target': 'object'}
2023-10-04 12:06:54,540 INFO Your 'pandas.DataFrame' is successfully wrapped by Giskard's 'Dataset' wrapper class.
2023-10-04 12:06:54,550 INFO Artifact enron/models/a3ddd357-1b4e-4935-a7c3-530062481332 already exists, skipping download
2023-10-04 12:06:54,561 INFO Artifact enron/datasets/e8e9483a-327d-432d-abd4-d1ddd4056943 already exists, skipping download
2023-10-04 12:06:54,617 INFO Casting dataframe columns from {'Content': 'object', 'Target': 'object'} to {'Content': 'object', 'Target': 'object'}
2023-10-04 12:06:54,628 INFO Your 'pandas.DataFrame' is successfully wrapped by Giskard's 'Dataset' wrapper class.
2023-10-04 12:06:54,638 INFO Artifact enron/models/a3ddd357-1b4e-4935-a7c3-530062481332 already exists, skipping download
2023-10-04 12:06:54,649 INFO Artifact enron/datasets/e8e9483a-327d-432d-abd4-d1ddd4056943 already exists, skipping download
2023-10-04 12:06:54,712 INFO Casting dataframe columns from {'Content': 'object', 'Target': 'object'} to {'Content': 'object', 'Target': 'object'}
2023-10-04 12:06:54,725 INFO Your 'pandas.DataFrame' is successfully wrapped by Giskard's 'Dataset' wrapper class.
2023-10-04 12:06:54,735 INFO Artifact enron/models/a3ddd357-1b4e-4935-a7c3-530062481332 already exists, skipping download
2023-10-04 12:06:54,749 INFO Artifact enron/datasets/e8e9483a-327d-432d-abd4-d1ddd4056943 already exists, skipping download
2023-10-04 12:06:54,800 INFO Casting dataframe columns from {'Content': 'object', 'Target': 'object'} to {'Content': 'object', 'Target': 'object'}
2023-10-04 12:06:54,813 INFO Your 'pandas.DataFrame' is successfully wrapped by Giskard's 'Dataset' wrapper class.
2023-10-04 12:06:54,823 INFO Artifact enron/models/a3ddd357-1b4e-4935-a7c3-530062481332 already exists, skipping download
2023-10-04 12:06:54,834 INFO Artifact enron/datasets/e8e9483a-327d-432d-abd4-d1ddd4056943 already exists, skipping download
2023-10-04 12:06:54,894 INFO Casting dataframe columns from {'Content': 'object', 'Target': 'object'} to {'Content': 'object', 'Target': 'object'}
2023-10-04 12:06:54,909 INFO Your 'pandas.DataFrame' is successfully wrapped by Giskard's 'Dataset' wrapper class.
2023-10-04 12:06:54,919 INFO Artifact enron/models/a3ddd357-1b4e-4935-a7c3-530062481332 already exists, skipping download
2023-10-04 12:06:54,931 INFO Artifact enron/datasets/e8e9483a-327d-432d-abd4-d1ddd4056943 already exists, skipping download
2023-10-04 12:06:54,989 INFO Casting dataframe columns from {'Content': 'object', 'Target': 'object'} to {'Content': 'object', 'Target': 'object'}
2023-10-04 12:06:55,003 INFO Your 'pandas.DataFrame' is successfully wrapped by Giskard's 'Dataset' wrapper class.
2023-10-04 12:06:55,014 INFO Artifact enron/models/a3ddd357-1b4e-4935-a7c3-530062481332 already exists, skipping download
2023-10-04 12:06:55,027 INFO Artifact enron/datasets/e8e9483a-327d-432d-abd4-d1ddd4056943 already exists, skipping download
2023-10-04 12:06:55,081 INFO Casting dataframe columns from {'Content': 'object', 'Target': 'object'} to {'Content': 'object', 'Target': 'object'}
2023-10-04 12:06:55,094 INFO Your 'pandas.DataFrame' is successfully wrapped by Giskard's 'Dataset' wrapper class.
2023-10-04 12:06:55,105 INFO Artifact enron/models/a3ddd357-1b4e-4935-a7c3-530062481332 already exists, skipping download
2023-10-04 12:06:55,118 INFO Artifact enron/datasets/e8e9483a-327d-432d-abd4-d1ddd4056943 already exists, skipping download
2023-10-04 12:06:55,174 INFO Casting dataframe columns from {'Content': 'object', 'Target': 'object'} to {'Content': 'object', 'Target': 'object'}
2023-10-04 12:06:55,186 INFO Your 'pandas.DataFrame' is successfully wrapped by Giskard's 'Dataset' wrapper class.
2023-10-04 12:06:55,195 INFO Artifact enron/models/a3ddd357-1b4e-4935-a7c3-530062481332 already exists, skipping download
2023-10-04 12:06:55,207 INFO Artifact enron/datasets/e8e9483a-327d-432d-abd4-d1ddd4056943 already exists, skipping download
2023-10-04 12:06:55,262 INFO Casting dataframe columns from {'Content': 'object', 'Target': 'object'} to {'Content': 'object', 'Target': 'object'}
2023-10-04 12:06:55,275 INFO Your 'pandas.DataFrame' is successfully wrapped by Giskard's 'Dataset' wrapper class.
2023-10-04 12:06:55,284 INFO Artifact enron/models/a3ddd357-1b4e-4935-a7c3-530062481332 already exists, skipping download
2023-10-04 12:06:55,296 INFO Artifact enron/datasets/e8e9483a-327d-432d-abd4-d1ddd4056943 already exists, skipping download
2023-10-04 12:06:55,347 INFO Casting dataframe columns from {'Content': 'object', 'Target': 'object'} to {'Content': 'object', 'Target': 'object'}
2023-10-04 12:06:55,359 INFO Your 'pandas.DataFrame' is successfully wrapped by Giskard's 'Dataset' wrapper class.
2023-10-04 12:06:55,377 ERROR An error occurred during the test suite execution: 400 Client Error:  for url: http://localhost:19000/api/v2/artifact-info/enron/datasets/%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20Content%20%20%20%20%20Target6%20%20calendar%5Cn----------------------%20Forwarded%20by%20...%20%20INFLUENCE
Traceback (most recent call last):
  File "/home/bazire/release-test/.venv/lib/python3.10/site-packages/requests/models.py", line 971, in json
    return complexjson.loads(self.text, **kwargs)
  File "/usr/lib/python3.10/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python3.10/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python3.10/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/bazire/release-test/.venv/lib/python3.10/site-packages/giskard/client/giskard_client.py", line 55, in build_response
    err_resp = response.json()
  File "/home/bazire/release-test/.venv/lib/python3.10/site-packages/requests/models.py", line 975, in json
    raise RequestsJSONDecodeError(e.msg, e.doc, e.pos)
requests.exceptions.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/bazire/release-test/.venv/lib/python3.10/site-packages/giskard/ml_worker/websocket/listener.py", line 512, in run_test_suite
    tests = [
  File "/home/bazire/release-test/.venv/lib/python3.10/site-packages/giskard/ml_worker/websocket/listener.py", line 515, in <listcomp>
    "arguments": parse_function_arguments(ml_worker, t.arguments),
  File "/home/bazire/release-test/.venv/lib/python3.10/site-packages/giskard/ml_worker/websocket/utils.py", line 171, in parse_function_arguments
    arguments[arg.name] = Dataset.download(
  File "/home/bazire/release-test/.venv/lib/python3.10/site-packages/giskard/datasets/base/__init__.py", line 556, in download
    client.load_artifact(local_dir, posixpath.join(project_key, "datasets", dataset_id))
  File "/home/bazire/release-test/.venv/lib/python3.10/site-packages/giskard/client/giskard_client.py", line 239, in load_artifact
    files = self._session.get("artifact-info/" + artifact_path)
  File "/home/bazire/release-test/.venv/lib/python3.10/site-packages/requests/sessions.py", line 602, in get
    return self.request("GET", url, **kwargs)
  File "/home/bazire/release-test/.venv/lib/python3.10/site-packages/requests_toolbelt/sessions.py", line 76, in request
    return super(BaseUrlSession, self).request(
  File "/home/bazire/release-test/.venv/lib/python3.10/site-packages/requests/sessions.py", line 589, in request
    resp = self.send(prep, **send_kwargs)
  File "/home/bazire/release-test/.venv/lib/python3.10/site-packages/requests/sessions.py", line 703, in send
    r = adapter.send(request, **kwargs)
  File "/home/bazire/release-test/.venv/lib/python3.10/site-packages/requests/adapters.py", line 538, in send
    return self.build_response(request, resp)
  File "/home/bazire/release-test/.venv/lib/python3.10/site-packages/giskard/client/giskard_client.py", line 59, in build_response
    response.raise_for_status()
  File "/home/bazire/release-test/.venv/lib/python3.10/site-packages/requests/models.py", line 1021, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 400 Client Error:  for url: http://localhost:19000/api/v2/artifact-info/enron/datasets/%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20Content%20%20%20%20%20Target6%20%20calendar%5Cn----------------------%20Forwarded%20by%20...%20%20INFLUENCE

Closes #GSK-1847

Hartorn requested a review from rabah-khalek October 5, 2023 10:48

Hartorn self-assigned this Oct 5, 2023

Hartorn marked this pull request as ready for review October 5, 2023 11:13

Hartorn force-pushed the feature/gsk-1840-cannot-install-giskard-with-poetry-directly branch from 085fe14 to 84d76fa Compare October 5, 2023 12:12

Hartorn force-pushed the feature/gsk-1847-enron-model-test-suite-cannot-be-run branch from f1a539d to f481eb0 Compare October 5, 2023 12:12

Hartorn force-pushed the feature/gsk-1840-cannot-install-giskard-with-poetry-directly branch from 84d76fa to 752285b Compare October 5, 2023 14:31

Hartorn requested a review from a team October 5, 2023 14:31

Hartorn force-pushed the feature/gsk-1847-enron-model-test-suite-cannot-be-run branch 2 times, most recently from 71c8e7f to 8e0cd97 Compare October 5, 2023 15:17

Base automatically changed from feature/gsk-1840-cannot-install-giskard-with-poetry-directly to main October 5, 2023 15:59

Hartorn added 2 commits October 5, 2023 08:59

Adding debug config for worker

ade4626

Fixing enron notebook for test suite to be runnable

d077df7

Closes #GSK-1847

Hartorn force-pushed the feature/gsk-1847-enron-model-test-suite-cannot-be-run branch from 8e0cd97 to d077df7 Compare October 5, 2023 16:01

Hartorn merged commit fc71229 into main Oct 5, 2023

Hartorn deleted the feature/gsk-1847-enron-model-test-suite-cannot-be-run branch October 5, 2023 17:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Feature/gsk 1847 enron model test suite cannot be run #1458

Feature/gsk 1847 enron model test suite cannot be run #1458

Hartorn commented Oct 5, 2023

Uh oh!

linear bot commented Oct 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Uh oh!

Feature/gsk 1847 enron model test suite cannot be run #1458

Feature/gsk 1847 enron model test suite cannot be run #1458

Conversation

Hartorn commented Oct 5, 2023

Description

Related Issue

Type of Change

Checklist

Uh oh!

linear bot commented Oct 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants