Skip to content

Fix docker build #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2023
Merged

Fix docker build #1432

merged 1 commit into from
Sep 29, 2023

Conversation

@Hartorn
Copy link
Member

@Hartorn Hartorn commented Sep 28, 2023 •
edited
Loading

Description

Fixing docker build (and python wheel upload) on main, to have an "edge" version

Passing build : https://github.com/Giskard-AI/giskard/actions/runs/6341601339

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@Hartorn Hartorn added the Docker Trigger Docker build for PR label Sep 28, 2023
@Hartorn Hartorn requested a review from Inokinoki September 28, 2023 15:21
@Hartorn Hartorn self-assigned this Sep 28, 2023
@Hartorn Hartorn force-pushed the feature/repair-build branch 3 times, most recently from f1ccf73 to 2e74df5 Compare September 28, 2023 16:18
@Hartorn Hartorn force-pushed the feature/repair-build branch from 2e74df5 to 9708eab Compare September 28, 2023 16:42
@Hartorn Hartorn marked this pull request as ready for review September 28, 2023 16:42
@Hartorn Hartorn requested a review from a team September 28, 2023 16:42
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Hartorn Hartorn merged commit 18a9e05 into main Sep 29, 2023
@Hartorn Hartorn deleted the feature/repair-build branch September 29, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Inokinoki Inokinoki Awaiting requested review from Inokinoki

Assignees

@Hartorn Hartorn

Labels

Docker Trigger Docker build for PR

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Hartorn