Skip to content

Conversation

@henchaves
Copy link
Member

Description

This PR solves a bug when a user tries to create a new feedback and a red message appears just below the modal displaying a backend error.

Basically, the backend was trying to create a feedback without a email from, generating an uncatched exception. Therefore, I added a default email from ([email protected]) to avoid this problem.

Related Issue

GSK-1790 (available on Linear)

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

@henchaves henchaves requested a review from Inokinoki September 25, 2023 20:06
@henchaves henchaves self-assigned this Sep 25, 2023
@linear
Copy link

linear bot commented Sep 25, 2023

@henchaves henchaves marked this pull request as ready for review September 25, 2023 20:06
@henchaves henchaves added the High priority Created by Linear-GitHub Sync label Sep 25, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@henchaves henchaves merged commit a1a9df4 into main Sep 26, 2023
@henchaves henchaves deleted the feature/gsk-1790-feedback-button-does-not-work-in-the-demo-environment branch September 26, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backend High priority Created by Linear-GitHub Sync

Development

Successfully merging this pull request may close these issues.

3 participants