Skip to content

Conversation

@Hartorn
Copy link
Member

@Hartorn Hartorn commented Sep 20, 2023

Slight improvement to not run integration tests on windows
Also avoid re-running not slow tests

@Hartorn Hartorn self-assigned this Sep 20, 2023
@Hartorn Hartorn marked this pull request as ready for review September 20, 2023 07:32
@Hartorn Hartorn requested a review from a team September 20, 2023 07:32
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mattbit
Copy link
Member

mattbit commented Sep 20, 2023

@Hartorn, why?

@Hartorn
Copy link
Member Author

Hartorn commented Sep 20, 2023

@Hartorn, why?

@mattbit Well, on windows runner, the nightly fails, because the whole workflow is taking more than 360minutes.
This is also linked to the fact we cannot used XDIST with more thant 1 on windows runner, else they run out of memory.

image

@mattbit
Copy link
Member

mattbit commented Sep 20, 2023

Well, on windows runner, the nightly fails, because the whole workflow is taking more than 360minutes.

Wait, is it the workflow on Windows that takes >360 min or you mean the combined time of testing on all platforms & python versions?

@Hartorn
Copy link
Member Author

Hartorn commented Sep 20, 2023

Well, on windows runner, the nightly fails, because the whole workflow is taking more than 360minutes.

Wait, is it the workflow on Windows that takes >360 min or you mean the combined time of testing on all platforms & python versions?

The workflow on Windows, including all integrations test, not the combined time.

Copy link
Contributor

@andreybavt andreybavt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as sub-task to re-enable "slow" tests for windows after investigating why they can't be run with GH runner:

https://linear.app/giskard/issue/GSK-1613/enable-slow-tests-on-windows

@andreybavt andreybavt merged commit 1ecb78c into main Sep 21, 2023
@andreybavt andreybavt deleted the feature/slight-improve-nightly branch September 21, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants