Skip to content

Conversation

@Hartorn
Copy link
Member

@Hartorn Hartorn commented Sep 19, 2023

Needs #1401 to be merged

Description

  • Detoxify has been removed and changed by the HuggingFace model, but the prediction do change a bit...
    I'm not sure why it's changing so much, but I guess we are not using the same weights exactly.
    Is it

Notes :
Pydantic >2 cannot be installed with tensorflow >=2.13, because of incompatible version typing-extensions

tensorflow/tensorflow#60687 (comment)
Should be fine in 2.14

@linear
Copy link

linear bot commented Sep 19, 2023

GSK-852 TensorFlow 2.11.0 not working on arm64

Reported error by hugo :

Hash for tensorflow (2.11.0) from archive tensorflow-2.11.0-cp37-cp37m-macosx_10_14_x86_64.whl not found in known hashes (was: sha256:2c8bde1bbffc2475809d7624bfebf1aec33ca222b60897f65e45e10719450f8e)

To try:

  • Setup arm instance on GCP
  • try to install py env with tensorflow 2.9

@Hartorn Hartorn self-assigned this Sep 19, 2023
@Hartorn Hartorn added the Docker Trigger Docker build for PR label Sep 19, 2023
@Hartorn Hartorn marked this pull request as ready for review September 19, 2023 12:45
@Hartorn Hartorn marked this pull request as draft September 19, 2023 12:47
@Hartorn Hartorn force-pushed the feature/improve-image-build branch from dc3698a to be48728 Compare September 19, 2023 12:49
@Hartorn Hartorn force-pushed the feature/GSK-852 branch 7 times, most recently from 217b1f5 to 1a85c48 Compare September 20, 2023 07:15
@Hartorn Hartorn changed the base branch from feature/improve-image-build to main September 20, 2023 07:16
@Hartorn Hartorn force-pushed the feature/GSK-852 branch 11 times, most recently from 7fe3243 to 28c714c Compare September 20, 2023 16:31
@Hartorn Hartorn marked this pull request as ready for review September 20, 2023 22:05
@Hartorn Hartorn requested a review from a team September 20, 2023 22:05
@Hartorn Hartorn changed the base branch from main to feature/gsk-1745-upgrade-pydantic-to-20 September 21, 2023 16:03
@Hartorn Hartorn marked this pull request as draft September 21, 2023 16:06
@Hartorn Hartorn requested a review from Inokinoki September 22, 2023 07:41
@Hartorn Hartorn force-pushed the feature/gsk-1745-upgrade-pydantic-to-20 branch from 15f418b to c467382 Compare September 22, 2023 09:07
Base automatically changed from feature/gsk-1745-upgrade-pydantic-to-20 to main September 22, 2023 09:51
@Hartorn Hartorn marked this pull request as ready for review September 22, 2023 09:53
@Hartorn Hartorn force-pushed the feature/GSK-852 branch 2 times, most recently from 04ef83d to 7a26a6c Compare September 25, 2023 12:19
@Inokinoki
Copy link
Member

Review finished.

I will try to test on Linux and macOS, with py3.11

@Hartorn Hartorn force-pushed the feature/GSK-852 branch 3 times, most recently from 8200204 to fcd1579 Compare September 28, 2023 08:37
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Hartorn Hartorn merged commit 55e527a into main Sep 28, 2023
@Hartorn Hartorn deleted the feature/GSK-852 branch September 28, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docker Trigger Docker build for PR

Development

Successfully merging this pull request may close these issues.

4 participants