Skip to content

Conversation

@Hartorn
Copy link
Member

@Hartorn Hartorn commented Sep 8, 2023

Experimentation to get better output in summary for python actions

Example with error in test here : https://github.com/Giskard-AI/giskard/actions/runs/6144369253#summary-16669640839

@Hartorn Hartorn self-assigned this Sep 8, 2023
@Hartorn Hartorn force-pushed the feature/github-summary branch 3 times, most recently from d4323bb to 2c272be Compare September 11, 2023 07:09
@Inokinoki
Copy link
Member

Nice work!
Does this task have already Linear card? I've created a card a few weeks ago, which seems to be related: https://linear.app/giskard/issue/GSK-1650/export-java-and-python-test-reports

@Hartorn
Copy link
Member Author

Hartorn commented Sep 11, 2023

Nice work! Does this task have already Linear card? I've created a card a few weeks ago, which seems to be related: https://linear.app/giskard/issue/GSK-1650/export-java-and-python-test-reports

The Windows part and CI splitting is in another part, the report part not so much.
I will reuse your card then

@Hartorn Hartorn force-pushed the feature/github-summary branch from 2c272be to 2eb17f7 Compare September 11, 2023 09:12
@Hartorn Hartorn changed the base branch from main to feature/gsk-1618-run-python-tests-on-windows-builder September 11, 2023 10:15
@Hartorn Hartorn changed the base branch from feature/gsk-1618-run-python-tests-on-windows-builder to main September 11, 2023 10:15
@Hartorn Hartorn force-pushed the feature/github-summary branch 2 times, most recently from c6c5a87 to 65644c7 Compare September 11, 2023 13:40
@Hartorn Hartorn marked this pull request as ready for review September 11, 2023 13:40
@andreybavt
Copy link
Contributor

@Hartorn could you also add a plain list of tests with their status under a collapsible section?
It'll be useful when making sure that a specific test has actually been executed

@andreybavt andreybavt self-requested a review September 12, 2023 15:02
Contributes to GSK-1650
@Hartorn Hartorn force-pushed the feature/github-summary branch from 65644c7 to a71c6a4 Compare September 12, 2023 17:14
@Hartorn Hartorn force-pushed the feature/github-summary branch from a71c6a4 to 9a0173d Compare September 12, 2023 17:33
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Hartorn
Copy link
Member Author

Hartorn commented Sep 12, 2023

@Hartorn could you also add a plain list of tests with their status under a collapsible section? It'll be useful when making sure that a specific test has actually been executed

Sure, done in the last version !
I've added something close for Gradle, but a bit more basic (still difficult for me to get a hand on Kotlyn script)

@andreybavt andreybavt merged commit 1f43a29 into main Sep 14, 2023
@andreybavt andreybavt deleted the feature/github-summary branch September 14, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants